Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Configuration of OidcTrustedDomains.js #1391

Open
timurscribe opened this issue Jun 20, 2024 · 4 comments
Open

Dynamic Configuration of OidcTrustedDomains.js #1391

timurscribe opened this issue Jun 20, 2024 · 4 comments

Comments

@timurscribe
Copy link

We currently have an app that retrieves configuration variables from the initial information request, which are then used to configure all endpoints and authentication URLs. Unfortunately, setting OidcTrustedDomains dynamically is not possible at the moment. It would be beneficial to have the ability to configure this dynamically.

@jw265982
Copy link

Support

@guillaume-chervet
Copy link
Contributor

Hi @timurscribe @jw265982 ,

Thank you for your issue.
It is possible to build it dynamicaly from your server side.
This his only secure way i know to do it.

@timurscribe
Copy link
Author

  1. Why is setting up a trusted domain on the client side not secure?
  2. How about a Post message to the web worker that provides a trusted domain and initiates the authorization process?
    Thanks in advance.

@meesvandongen
Copy link
Contributor

  1. Why is setting up a trusted domain on the client side not secure?

Part of the goal of using a service worker is that if someone evil has gained the ability to execute javascript on the page of the user, they would not be able to steal the access token (as they cannot execute JS inside the service worker). If they can configure the domain, they can work around this by sending the token to their own server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants