Performs a secondary cleanup attempt in isolate-test.sh in case the first one fails
#1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around a race condiditon that occurs reliably when the `xdg-desktop-portal` package is installed. When this triggers, the output looks like: ``` $.../scripts/isolate-test.sh .../scripts/image-test.py .../build/src/geeqie .../build/test-images.p/images/JPG_MINOLTA_RD175.JPG Variables in isolated environment: G_DEBUG=fatal-critical HOME=/tmp/tmp.uCSyUTWVkw XDG_CONFIG_HOME=/tmp/tmp.uCSyUTWVkw/.config XDG_RUNTIME_DIR=/tmp/tmp.uCSyUTWVkw/.runtime DBUS_SESSION_BUS_ADDRESS=unix:path=/tmp/dbus-Nou8YYvYti,guid=9de5a10c77563265a7e1c9b167214161 [...] Warning: Failed to convert Exif.Photo.DateTimeOriginal to Xmp.photoshop.DateCreated, unable to parse '19ff:1f:3f 3f:7f:00' Warning: Failed to convert Exif.Photo.DateTimeDigitized to Xmp.xmp.CreateDate, unable to parse '19ff:1f:3f 3f:7f:00' rm: cannot remove '/tmp/tmp.uCSyUTWVkw/.runtime/doc': Is a directory First cleanup attempt failed; sleeping and retrying... removed directory '/tmp/tmp.uCSyUTWVkw/.runtime/doc' removed directory '/tmp/tmp.uCSyUTWVkw/.runtime' removed directory '/tmp/tmp.uCSyUTWVkw' ```
|
Implemented in commit 9e5a7eb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around a race condiditon that occurs reliably when the
xdg-desktop-portalpackage is installed.When this triggers, the output looks like:
Fixes #1532