SlatePlugin implementation #291
Replies: 5 comments 3 replies
-
Hi @Hideman85, thanks so much for this/implementation. Sadly I don't think it's a good idea to integrate with 3rd party plugin systems in this repository since that will most likely will result in a lot of operational overhead in the future. IMO this should live in a separate repository/package. I'd be happy to add it to the readme if you publish it. |
Beta Was this translation helpful? Give feedback.
-
I think we could create a gist and link it and I agree with you this is better to not add the extra deps for "nothing". |
Beta Was this translation helpful? Give feedback.
-
I'll convert this into a discussion to keep as a reference |
Beta Was this translation helpful? Give feedback.
-
Hi @Hideman85, |
Beta Was this translation helpful? Give feedback.
-
Hi @Hideman85, |
Beta Was this translation helpful? Give feedback.
-
I'm just starting implementing Yjs into my editor, and I'm using SlatePlugin modeling, so I just started looking at your sample and did a first draft of a SlatePlugin (gonna update it if needed).
I just have one feedback related to
useCursor
could it be simplified by using only(sharedType, provider)
as parameters instead of the full editor? I mean, I checked out the code and nothing is related to the editor itself and in the case of SlatePlugin it is complicated to have the editor declared at this right moment (look at the code below).Beta Was this translation helpful? Give feedback.
All reactions