-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide the UITextField inside the SHSearchBar #9
Labels
Milestone
Comments
His, Can you assign me this issue ? |
With pleasure :) |
But wait… Here I'm not sure if I actually want this, which is the reason why I did not add the label |
you unassigned me ? this issue not part of the #hacktoberfest ? |
I added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It is important to hide the text field behind a public API. This enables to switch technologies behind the SHSearchBar without affecting users of the framework.
Here it is important to offer all the functionality in the public API like the normal UISearchBar does plus advantages a UITextField has. These are:
UITextField Features
[set/get] defaultTextAttributes
[set/get] typingAttributes
(the above 2 are better than setting the attributedText directly since we are able to access the attributes and thus are more flexible)
[set/get] attributedPlaceholder
[set/get] leftView
[set/get] rightView
[set/get] tintColor (directly maps to the cursor color)
[set/get] text
[set/get] isEnabled
[call] resignFirstResponder()
SHSearchBar Features
The text was updated successfully, but these errors were encountered: