We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PartialCellBottom
I think I found a bug in the PartialCellBottom code. The definition of volumes for ImmersedBoundaryGrids
Oceananigans.jl/src/ImmersedBoundaries/immersed_grid_metrics.jl
Line 26 in d289fed
Oceananigans.jl/src/Operators/spacings_and_areas_and_volumes.jl
Line 263 in d289fed
Therefore, not accounting for reduced spacing in volumes. The same happens for vertical areas. I will open a PR to fix it.
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
I think I found a bug in the
PartialCellBottom
code.The definition of volumes for ImmersedBoundaryGrids
Oceananigans.jl/src/ImmersedBoundaries/immersed_grid_metrics.jl
Line 26 in d289fed
bypasses the calculation of the volumes done in
Oceananigans.jl/src/Operators/spacings_and_areas_and_volumes.jl
Line 263 in d289fed
Therefore, not accounting for reduced spacing in volumes. The same happens for vertical areas.
I will open a PR to fix it.
The text was updated successfully, but these errors were encountered: