Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with PartialCellBottom #3958

Open
simone-silvestri opened this issue Nov 25, 2024 · 0 comments · May be fixed by #3955
Open

Issue with PartialCellBottom #3958

simone-silvestri opened this issue Nov 25, 2024 · 0 comments · May be fixed by #3955

Comments

@simone-silvestri
Copy link
Collaborator

simone-silvestri commented Nov 25, 2024

I think I found a bug in the PartialCellBottom code.
The definition of volumes for ImmersedBoundaryGrids

@inline $volume(i, j, k, ibg::IBG) = $volume(i, j, k, ibg.underlying_grid)

bypasses the calculation of the volumes done in
@inline $volume(i, j, k, grid) = $z_area(i, j, k, grid) * $z_spacing(i, j, k, grid)

Therefore, not accounting for reduced spacing in volumes. The same happens for vertical areas.
I will open a PR to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant