Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiling doesn't work with tinybench plugin #37

Open
XantreDev opened this issue Aug 13, 2024 · 1 comment
Open

Profiling doesn't work with tinybench plugin #37

XantreDev opened this issue Aug 13, 2024 · 1 comment

Comments

@XantreDev
Copy link

Profiling doesn't work with tinybench
image
profiling
source

Profiling works with vitest
image
profiling
source

@adriencaccia
Copy link
Member

Hey @XantreDev, thanks for the issue.

I managed to dig a bit and it seems that the problem is a mix of reasons: using yarn, the CodSpeed action and tinybench with TS.

Investigation

We can see here that the node introspection is not working, the node flags are set only on the yarn bench command and not the underlying node ... command.

When manually calling the node ... command instead of yarn bench in the GH workflow file, the introspection works as expected (see here).

We did not face this problem before because most users are using pnpm, which actually runs the underlying node ... command when executing a script.

Workaround

The process is much simpler when using vitest and it works as expected, even with yarn.

I will keep this issue open, since we might want a fix in the future if others face the same issue again.

@art049 art049 added the Migrated label Nov 25, 2024 — with Linear
@art049 art049 removed the Migrated label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants