Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System Message Broadcasts #73

Open
AtHeartEngineer opened this issue Sep 2, 2023 · 0 comments
Open

System Message Broadcasts #73

AtHeartEngineer opened this issue Sep 2, 2023 · 0 comments
Assignees
@Codetrauma

Comments

@AtHeartEngineer
Copy link
Contributor

AtHeartEngineer commented Sep 2, 2023 •
edited
Loading

server/src/websockets/index.ts

Line 71 in b37e809

socket.on('systemMessage', (msg: string, roomID: bigint) => {

This needs to be removed. socket.on('systemMessage') allows any client to be able to broadcast using that method.

We should be passing the io object to the createmessage
@AtHeartEngineer AtHeartEngineer converted this from a draft issue Sep 2, 2023
@Codetrauma Codetrauma moved this from 🔖 Ready to be worked on to 🏗 In progress in Discreetly Sep 6, 2023
@AtHeartEngineer AtHeartEngineer moved this from 🏗 In progress to 👀 In review/testing in Discreetly Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Codetrauma Codetrauma

Labels
None yet
Projects
Discreetly
Status: 👀 In review/testing
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AtHeartEngineer @Codetrauma