Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MessagePack for serialization #261

Open
djsutho opened this issue Nov 5, 2018 · 2 comments
Open

Use MessagePack for serialization #261

djsutho opened this issue Nov 5, 2018 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@djsutho
Copy link
Contributor

djsutho commented Nov 5, 2018

Currently we are using json for data serialization to/from kafka topics.

We should have the option of using MessagePack throughout the system as it has performance benefits and it makes it consistent with the ingest topic which defaults to using MessagePack.
@williewheeler williewheeler added the enhancement New feature or request label Nov 6, 2018
@williewheeler
Copy link
Contributor

We have a Kafka serde for MetricData, but we need serdes for the other data types too (e.g. MappedMetricData, Anomaly). MessagePack requires us to hand-craft these on a per-type basis.

@williewheeler williewheeler added the good first issue Good for newcomers label Nov 7, 2018
@djsutho
Copy link
Contributor Author

djsutho commented Nov 9, 2018

Actually might just be able to copy the json implementation and use this https://github.com/msgpack/msgpack-java/tree/develop/msgpack-jackson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@williewheeler @djsutho