Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Enable Preferred Viewing Mode by Default #5427

Open
3 tasks done
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Jul 18, 2024 · 9 comments · May be fixed by #5903
Open
3 tasks done

[Feature Request]: Enable Preferred Viewing Mode by Default #5427

efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Jul 18, 2024 · 9 comments · May be fixed by #5903
Assignees
Labels

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Jul 18, 2024

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

Only option users have is to Enable Theatre Mode by Default but not for the other viewing modes.

Proposed Solution

Create a dropdown in the player settings called Default Viewing Mode with the following values:

  • Default
  • Theatre
  • Picture-In-Picture
  • Full Window
  • Fullscreen
  • External player

Alternatives Considered

None.

Issue Labels

ease of use improvement

Additional Information

No response

@lazyb5
Copy link

lazyb5 commented Jul 18, 2024

I would love to see these settings implemented!

@ParasiteDelta
Copy link

ParasiteDelta commented Aug 7, 2024

I was just coming to file this. Alongside the lack of a button to play all videos from a channel, or a button to shuffle all videos from a channel, this is a constant annoyance when using FreeTube. Every single time the video changes, it defaults back to standard view, ripping me out of theater fullscreen and frustrating me when I go to look for a minute or two at my playlist and find that the video is partially off-screen or not focused. However, between this and GlazeWM, it provides a good dev environment for background noise when it works.

@xlacroixx
Copy link

Here checking in for #2332.

I saw that the project was migrating their player; have they done it? Otherwise I might look into doing a PR if it's easy even for a non-web dev.

@0Raik
Copy link

0Raik commented Oct 10, 2024

👍
It's sad that most of us aren't developers and the few there are don't program the same language, otherwise I would absolutely contribute to this project ❤️

Thanks to all the developers and contributors that expend their time and effort to this amazing project. Thank you!

@kommunarr kommunarr assigned kommunarr and unassigned kommunarr Oct 20, 2024
@kommunarr
Copy link
Collaborator

kommunarr commented Oct 20, 2024

No idea on how to implement default fullscreen without a big change to our current implementation. Requesting fullscreen programmatically without user interaction is blocked by the Fullscreen API, and I don't think we can cleanly bypass that.

Edit: Never mind, I completely forgot about executeJavascript.

@0Raik
Copy link

0Raik commented Oct 20, 2024

I could settle with full window video but if there's a will, there's a way.

@kommunarr kommunarr self-assigned this Oct 20, 2024
@kommunarr
Copy link
Collaborator

kommunarr commented Oct 20, 2024

Notes:

  • I still think we should keep the Enable Theater Mode By Default setting, as it is not mutually exclusive with the other viewing modes.
  • One possible follow up is a secondary default viewing mode when PiP/Fullscreen/Fullwindow is set as the primary. That way, the user can configure themselves to be in PiP (A floating popup of currently playing video when scrolling through videos #1028)/Fullwindow when exiting the above.
    • Edit: I wrote this part when I was still unsure about keeping the Enable Theater Mode by Default setting, but now that I'm sure on keeping it, this is pretty much only desired for PiP. It seems like A floating popup of currently playing video when scrolling through videos #1028 is more about engaging PiP whenever the video is not visible, which seems like a wholly separate condition being checked and should not be directly associated with any of this.

@valtoree
Copy link

valtoree commented Nov 2, 2024

Hi, what amazing work all the dev/s have done ty ty 🙏 I would also love this feature to save me a click to always fullscreen the videos. Keep up the great work ❤️

@Suburban-Vampire
Copy link

Came here to add my +1 on this feature.

My use case is that I run FreeTube on a secondary display and kick links to it via browser, so I generally would like to autoplay and auto-fullscreen all received links when operating this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To assign
Development

Successfully merging a pull request may close this issue.

8 participants