Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approval for main Awesome list #91

Open
16 of 18 tasks
EliteMasterEric opened this issue Feb 16, 2023 · 13 comments
Open
16 of 18 tasks

Approval for main Awesome list #91

EliteMasterEric opened this issue Feb 16, 2023 · 13 comments

Comments

@EliteMasterEric
Copy link
Member

EliteMasterEric commented Feb 16, 2023

See linked issue: sindresorhus/awesome#2503

Various small issues block the actual addition of this list to the main directory of resources. Those will be listed here and checked off as they are resolved:

  • Rewrite entry description (see my review of the PR).
  • Enable automatic linting using awesome-lint.
  • Resolve all linting issues.
  • Await 30 days from first commit (February 23rd).
  • Rewrite header and summary description.
  • lower-kebab-case-repo-name
  • Title Case Heading Title
  • Set Github Topics tags
  • Move deprecated entries to a separate file.
  • Add logo to the header.
  • Add link to logo.
  • Include Awesome badge
  • Revise table of contents
  • Use CC0 license for list itself.
  • Add Footnotes section to readme (excluded from ToC)
  • Move further reading to footnotes section
  • Protect main branch
  • Disallow one-click merging of pull requests with style issues
@EliteMasterEric
Copy link
Member Author

@lime360 as the submitter of the PR on Awesome's side.

@ninjamuffin99
Copy link
Member

nice work !!!

@ghost
Copy link

ghost commented Feb 19, 2023

thx

@BombasticTom
Copy link
Contributor

it's been 30 days from the first commit

@EliteMasterEric
Copy link
Member Author

@BombasticTom Yep! With that, looks like all linting checks currently pass on the main branch.

@ninjamuffin99
Copy link
Member

@EliteMasterEric I made main a protected branch, what entails for Disallow one-click merging of pull requests with style issues?

@EliteMasterEric
Copy link
Member Author

EliteMasterEric commented Mar 11, 2023

@EliteMasterEric I made main a protected branch, what entails for Disallow one-click merging of pull requests with style issues?

There is a GitHub Action on this repo that adds a build action, which performs style checking using a library built by the creators of the Awesome list.

There should be an option that disallows merging pull requests with build failures on them. So if the person's PR has style issues that need to be fixed we can't merge it by mistake.

EDIT the option is called Require status checks to pass before merging

So if the status of the PR is failure you can't merge it

@EliteMasterEric EliteMasterEric pinned this issue Mar 30, 2023
@EliteMasterEric
Copy link
Member Author

pinning this till we get it done

@ghost
Copy link

ghost commented May 4, 2023

for people who don't know: I am the one who suggested this to be on main awesome list

@BombasticTom
Copy link
Contributor

nice

@EliteMasterEric
Copy link
Member Author

@lime360 please address this comment:

https://github.com/sindresorhus/awesome/pull/2503/files#r1123587843

@EliteMasterEric
Copy link
Member Author

It appears that Lime360 has deleted their account.

TODO: Submit a new request for approval on the Awesome list.

@BombasticTom
Copy link
Contributor

are the last 2 things resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants