Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make menu items consistent (phase 1: Jadeite, Project, Method list pane, Method text pane) #36

Open
8 of 18 tasks
LisaAlmarode opened this issue Nov 15, 2023 · 1 comment
Assignees
Labels
F3-Enhancement Feature for convenience or ease of use

Comments

@LisaAlmarode
Copy link
Member

LisaAlmarode commented Nov 15, 2023

I've examined four menus between JadeiteForPharo (PJ here) and the Dolphin based product (DJ). (See below for screenshots).
The following are recommendations on changes to improve consistency (without implementing new features).
Plus one hard problem: execute/do it and friend's menu item name and shortcut...

Project Browser Dropdown Jadeite

  • New Browser - rename to New Projects Browser (to match DJ)
  • New Browser Tab - rename to New Projects Tab (to match DJ)

Project Browser Popup MethodList pane

  • remove Browse Class, not on this menu in DJ and also not working

  • reorder these to match DJ, order should be :
    Browse Methods Containing ...
    Browse Literal References ...
    Browse Selected Methods

Project Browser Popup ProjectList pane

  • order should be:
    Load ...
    Refresh from Disk
    Unload ...
    ------
    Commit to Git ...
    Push to GitHub
    ------
    Changes
    Write to Git ...

  • Rename Unload ... to Unload (no further options so no ...)

  • Rename 'Push to GitHub' to 'Push to Git'

  • Should rename 'Write to Git'. in DJ it's 'Write ...' but probably should be 'Write'. I don't think Write to Git is correct.

Project Browser Popup Text pane (method selected)
The order is quite different and it's not so obvious what's correct.

  • These we need to decide on the menu item names, if we use the JD or JP styles.

  • And on the shortcuts - I don't think we can handle them being different, but they need to match the name

  • And on the position in the menu, which is lower down in DJ
    Debug it (control-D) (in DJ, just Debug, control-b position 13)
    Do it (control-d) (in DJ, Execute, control-e position 15)
    Inspect it (control-i) (in DJ, just Inspect, control-q position 16)
    Print it (control-p) (in DJ, Display , control-d position 14)

  • Remove non-working items (I believe) on Code search sub menu, all these:
    Browse full class
    References to it
    Case insensitive method literals with it
    Case sensitive method literals with it
    Method source with it

  • move implementors and senders to the upper level menu. It just makes more sense.
    If we get all the above items working we could reintroduce the submenu...

  • These aren't implemented and don't make a whole lot of sense in this menu, so let's remove them.
    File actions >
    File in Server File ...
    File in Selected Text

  • Format Source doesn't match DJ's Reformat Source, could rename in PJ or DJ, either name is OK with me

  • Cut-copy-paste need to actually be in Cut-Copy-Paste order.
    Then we need to decide if these items are higher or lower on the menu.
    Copy
    Cut
    Paste

  • Remove Paste ... (I don't know what this does, if anything; not in DJ)

  • Save/cancel... Not sure what to do here... the names are different and menu locations very different.
    Accept In DJ: Save
    Cancel In DJ: Revert
    We could probably leave the names the same (that is, not consistent between PJ and DJ)
    JP, Pharo and VW7 use Accept/Cancel, JD and VA11 use Save/Revert, and the position on the menu is different in DJ, DP, VW7, VA11.

Menu screen shots for reference:
D-BrowserJadeiteDropdown

D-BrowserProjectPanePopup

D-BrowserMethodPanePopup

D-BrowserTextPopup

@LisaAlmarode LisaAlmarode added the F3-Enhancement Feature for convenience or ease of use label Nov 15, 2023
@ericwinger
Copy link
Member

Project Browser Popup Text pane (method selected)
The order is quite different and it's not so obvious what's correct.

A note about the text popup pane. I took the pharo text popup menu and modified it to do GemStone functions. (at least some of the menu options). It will require a complete overhaul when we've decided what's to be done.

ericwinger added a commit that referenced this issue Nov 15, 2023
Add whenNone* event block to better clear filter and method panes. 
Fix Browse Class method list popup menu option. 
#36
Port browser test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F3-Enhancement Feature for convenience or ease of use
Projects
None yet
Development

No branches or pull requests

2 participants