Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3) during project load, existing required project is "forcibly" reloaded AND cloned in different repository ... not expected #905

Open
dalehenrich opened this issue Oct 6, 2023 · 2 comments
Assignees
Labels
First Release For July 31st deadline

Comments

@dalehenrich
Copy link
Member

The project is Announcements and it has been cloned to $STONES_HOME/$registry/gs_projects prior to running this install script:

export ROWAN_PROJECTS_HOME=$STONES_HOME/test_git
bin/installProject.stone file:$STONES_HOME/$registry/gs_projects/Announcements/rowan/specs/Announcements.ston \
  --projectsHome=$STONES_HOME/$registry/gs_projects

At this point the git url is (with expanded env vars), as expected:

'file:/bosch1/users/dhenrich/_stones/test_rowanV3/gs_projects/Announcements'

Then RemoteServiceReplication is loaded using this install script (Announcements is a required by RemoteServiceReplication):

bin/installProject.stone file:$STONES_HOME/$registry/common_projects/RemoteServiceReplication/rowan/specs/RemoteServiceReplication.ston  \
  --projectsHome=$STONES_HOME/$registry/common_projects 

At this point the git url is (with expanded env vars):

`'file:/bosch1/users/dhenrich/_stones/test_git/Announcements'

and has been freshly cloned in ROWAN_PROJECTS_HOME ...

Since Announcements was already present in the image, I expected the existing project to be used and THAT IS NOT THE CASE.

As a related issue, when the required projects are loaded, they end up using ROWAN_PROJECTS_HOME and not --projectsHome which is also unexpected.

@dalehenrich dalehenrich self-assigned this Oct 6, 2023
dalehenrich added a commit to GsDevKit/GsDevKit_stones that referenced this issue Oct 6, 2023
…ncements in rowanV3_common along with RemoteServiceReplication because that's the best I can do with bin/installProject.stone, until the bug is fixed in v3; local tests are passing
@dalehenrich
Copy link
Member Author

dalehenrich commented Apr 9, 2024

I think that this is related to #912 and #926... need some tests

@dalehenrich
Copy link
Member Author

Regarding the code in GsDevKit_stones commit: 380e2d2 ... first check if v2.1 is different already ... then consider using loadedLoadSpecs since that is a better way to work with a collection of related projects...

@dalehenrich dalehenrich added the First Release For July 31st deadline label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First Release For July 31st deadline
Projects
None yet
Development

No branches or pull requests

1 participant