Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The current CSS for discussion triggers a heap of errors due to a missing ID #178

Open
psmits1567 opened this issue Jul 1, 2023 · 10 comments
Labels
bug Something isn't working

Comments

@psmits1567
Copy link

I notice a lot of errors when translating a page. The error is generated because the CSS style misses an ID that if referred to with "LABEL"
image
See the complete info of the error within the image
It is easy to reproduce

  1. Open the console before opening a project.
  2. As soon as the project opens and shows the table, the error is generated for each line
@psmits1567 psmits1567 added the bug Something isn't working label Jul 1, 2023
@amieiro
Copy link
Member

amieiro commented Sep 5, 2023

Hi, @psmits1567

I have tried to reproduce this problem, but I was not able to do it. The steps I did:

Can you give us the concrete steps, with URLs, to reproduce this error? Please, disable any browser extension related with translate.wordpress.org before doing this. Thank you.

@psmits1567
Copy link
Author

Hi some more info
Open a project that has waiting or fuzzy strings
Select fuzzies, the fuzzies are shown in a list, then select the first fuzzie record. Watch the errors indication on the upper right side of the console. That gives a red count if errors, which you can click on. Then you will see the reason for the errors

@psmits1567
Copy link
Author

This also happens with waiting strings

@amieiro
Copy link
Member

amieiro commented Sep 5, 2023

Hi @psmits1567

I try to reproduce this error with this project in Portuguese (Brazil), with strings in fuzzy and waiting status. I was not able to reproduce the errors:

Can you share some specific links and screenshots? Thank you

@psmits1567
Copy link
Author

@amieiro can you try with the Dutch locale "nl"
Unfortunately we have no current and waiting at this moment. I will try to catch some screenshots tomorrow

@psmits1567
Copy link
Author

@psmits1567
Copy link
Author

I tested on this project without any addons active
It is the checkbox at the beginning of the row that misses an attribute. And the discussion tab misses info

@psmits1567
Copy link
Author

label
feedback-comment
checkbox-issue

@psmits1567
Copy link
Author

If I open a list with untranslated lines, then translate the line and save it, the same errors arrive. All other labels on the page have a function behind, or is "area-label"

@psmits1567
Copy link
Author

Problem is still present as indicating an issue, it is not blocking but clutters the console
A form field element has neither an id nor a name attribute. This might prevent the browser from correctly autofilling the form.
To fix this issue, add a unique id or name attribute to a form field. This is not strictly needed, but still recommended even if you have an autocomplete attribute on the same element.
If we give the 'checkbox' an ID, it will be gone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants