Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#requestString broken when using strings instead #78

Open
marianopeck opened this issue Jun 25, 2015 · 1 comment
Open

#requestString broken when using strings instead #78

marianopeck opened this issue Jun 25, 2015 · 1 comment
Milestone
3.1.4.3

Comments

@marianopeck
Copy link
Contributor

Because of #64 in which we store strings rather than native request, the requestString of WAObjectLogEntry fails. In #71 @dalehenrich recommends adding a new instVar requestString. I agree with that. And we should fix all senders of WAObjectLogEntry which pass a request...
@marianopeck marianopeck added this to the 3.1.4.2 milestone Jun 25, 2015
@jbrichau
Copy link
Member

jbrichau commented Sep 5, 2015

So, for Seaside 3.1.4.2, I will just 'fix' the persistence of the request by adding a variable requestString, essentially making the request instvar unused by the standard implementation.

In Seaside 3.2.x, I think about having a try to persist a WARequest instance, so it does not persist a socket but we still have all info about the request in the log.

@dalehenrich dalehenrich modified the milestones: 3.1.4.2, 3.1.4.3 Oct 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.4.3
Development

No branches or pull requests
3 participants
@dalehenrich @jbrichau @marianopeck