Skip to content
This repository has been archived by the owner on Mar 29, 2021. It is now read-only.

Do we want a CSS-preprocessor? #143

Closed
Idrinth opened this issue Sep 19, 2016 · 10 comments
Closed

Do we want a CSS-preprocessor? #143

Idrinth opened this issue Sep 19, 2016 · 10 comments

Comments

@Idrinth
Copy link
Member

Idrinth commented Sep 19, 2016

I'm just wondering, if there might be use for a preprocessor once we cleaned up the current css in #142 . That might be especially useful, once you, @w20k , start on the redesign you planned on doing in the beginning ;)

@Idrinth
Copy link
Member Author

Idrinth commented Sep 19, 2016

https://csspre.com/compare/ just as a resource, I'm sure there's some more

@w20k
Copy link
Collaborator

w20k commented Sep 19, 2016

Or we could use something like this. If we tend to have complex structure.
https://github.com/tachyons-css/tachyons

I will, next month probably, still on business trips, for few more weeks ;(

@Idrinth
Copy link
Member Author

Idrinth commented Sep 19, 2016

My idea was mostly about making the actual css easier to read - we do have a lot of gui elements for a script this small, so anything we can live without should help a lot in maintaining it.

tachyons seems to be overkill here, after we aren't building a complete website and merely a few modules for it.

@w20k
Copy link
Collaborator

w20k commented Sep 19, 2016

It depends how you use it (tachyons - could be just headers or skeleton). But you state it this way, I'd use SCSS (it's my preference). For small projects there is no big difference in thouse :)

@Idrinth
Copy link
Member Author

Idrinth commented Sep 19, 2016

we got a few implementations in any case, just a quick look gave me the following one as the most commonly used basis for others:
https://github.com/leafo/scssphp

Not sure if I'd consider that stable judging from the issues it has listed, but well, neither is our code here.

@Idrinth Idrinth added this to the Low effort expected milestone Oct 3, 2016
@Idrinth
Copy link
Member Author

Idrinth commented Oct 4, 2016

@w20k since you're starting on the style changes, would SCSS help you? Could easily add it to a api-call.

@w20k
Copy link
Collaborator

w20k commented Oct 4, 2016

@Idrinth - Would be great - do it ;)

@Idrinth
Copy link
Member Author

Idrinth commented Oct 4, 2016

https://dotd.idrinth.de/kongregate/userscript-styles/[branch]/ should now provide the parsed contents of a root.scss in /src - minification for the master obviously, works pretty much the same as the userscript-page.

hope that works, @w20k

@w20k
Copy link
Collaborator

w20k commented Oct 4, 2016

Much appreciated @Idrinth ;)

@Idrinth
Copy link
Member Author

Idrinth commented Oct 4, 2016

we are using leafo's implementation, the one linked above, should work fine with imports as well if necessary :)

@Idrinth Idrinth closed this as completed Oct 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants