Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old Hold Sustain option doesn't do anything. #745

Closed
CoolDudeT opened this issue Nov 16, 2024 · 7 comments
Closed

Old Hold Sustain option doesn't do anything. #745

CoolDudeT opened this issue Nov 16, 2024 · 7 comments
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@CoolDudeT
Copy link

Describe your bug here. If you are modding, try testing your bug in a clean version of the engine instead. Also, if you're using an older version of JSE, please try the latest version/action build. Also, be sure to check the pinned 'JS Engine: Known Issues' issue, to check if your issue hasn't already been found!

Not sure if it's related to having note colors off or not, but turning on the Old Hold Sustain option doesn't do shit.

Command Prompt/Terminal/Crash logs (if existing)

No response

Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.

  1. Go to Options
  2. Go to Visuals and UI
  3. Turn on Old Hold Sustain (or whatever it's called.)
  4. Go out of options and play any song with a hold note.
  5. Hold splashes should still be there.

Are you modding a build from source or with Lua?

Lua

What is your build target?

Android

Did you edit anything in this build? If so, mention or summarize your changes.

No. (Unless turning off Note Colors counts.)

If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?

None

Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.

Yes

@CoolDudeT CoolDudeT added the bug Something isn't working label Nov 16, 2024
@StinkTheStinker
Copy link

let me look into the source code real quick

@StinkTheStinker
Copy link

image

is this the option you are talking about

@moxie-coder
Copy link
Collaborator

I don’t get what you mean honestly

@StinkTheStinker
Copy link

yeah same
just guessing at this point

@CoolDudeT
Copy link
Author

image

is this the option you are talking about

yeah that (sorry for taking so long to respond my bad)

@JordanSantiagoYT
Copy link
Owner

so um..........

turning that on only makes it so characters play an anim on sustain notes, it doesn't disable the hold splashes

@moxie-coder
Copy link
Collaborator

so um..........

turning that on only makes it so characters play an anim on sustain notes, it doesn't disable the hold splashes

because there isn't an option for it rn

@moxie-coder moxie-coder closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2024
@moxie-coder moxie-coder added the invalid This doesn't seem right label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

4 participants