Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition 'doubleSnapshotConfig.allowDoubleSnapshot()' should be negated #566

Open
wangsfx opened this issue May 30, 2022 · 0 comments
Open

Comments

@wangsfx
Copy link

wangsfx commented May 30, 2022

if (doubleSnapshotConfig.allowDoubleSnapshot() && failedTransitionTracker.anyTransitionWasFailed(updatePlan)) {

The code is inconsistent with the comments 'If the consumer is configured to only follow deltas (no double snapshot) then any failure to transition will cause the consumer to become "stuck" on stale data', so the condition 'doubleSnapshotConfig.allowDoubleSnapshot()' should be negated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant