Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shallow realisations should go back to using regular drv paths #11897

Open
Ericson2314 opened this issue Nov 18, 2024 · 0 comments
Open

Shallow realisations should go back to using regular drv paths #11897

Ericson2314 opened this issue Nov 18, 2024 · 0 comments

Comments

@Ericson2314
Copy link
Member

This works especially nicely in conjunction with #11896

For deep realisations, using "derivation hashes modulo" helps save space. But for shallow ones, it achieves nothing, since those are already keyed on resolved derivations, which are always distinct modulo ways of producing inputs.

For shallow ones, we should just go back to using store paths, which will be simpler, and save implementations that only care about CA derivations from having to implement the cumbersome and ATerm-encumbered "derivation hash modulo" algorithm.

This is tantamount to reverting bab1cda for shallow realisations; note that that affects all derivations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant