Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] rename migration folder #129

Open
legalsylvain opened this issue Oct 7, 2020 · 6 comments
Open

[RFC] rename migration folder #129

legalsylvain opened this issue Oct 7, 2020 · 6 comments
Labels
Bot Task A task the bot does or should do enhancement New feature or request

Comments

@legalsylvain
Copy link
Collaborator

When making a patch on a migration script, we have to rename the migration folder with the same name as the bumped revision. It could be automated.

I think that it could be an option of the ocabot. like bump-migration. the patch / minor / nobump / major is a choice of the people that are merging. (maintainers) not a choice of the developper.

CC : @sbidoul : what do you think ?

Ref : OCA/server-ux#213

@sbidoul sbidoul added Bot Task A task the bot does or should do enhancement New feature or request labels Nov 3, 2020
@sbidoul
Copy link
Member

sbidoul commented Nov 3, 2020

Sounds interesting.

@hparfr
Copy link

hparfr commented Mar 28, 2024

Hi,

I think we can achieve it if in the merge requests we:

    1. tell the developper puts the migrations scripts in the directory 0.0.0/
    1. adapt oca-ci, to always increment version number of the module before running the tests
    1. adapt oca-bot bump to rename the directory 0.0.0 to the new version number
  1. should be possible according to odoo
        A special folder named ``0.0.0`` can contain scripts that will be run on any version change.
  1. with a temporary / throw-away version number like major.minor.patch+1

@hparfr
Copy link

hparfr commented Mar 29, 2024

FYI @sebastienbeau

@legalsylvain
Copy link
Collaborator Author

tell the developper puts the migrations scripts in the directory 0.0.0/

That can not be asked to developpers. Sometimes, it is not possible to write idempotens scripts.

@hparfr
Copy link

hparfr commented Mar 30, 2024

I don't think migrations scripts have to be idempotants.

It should allow to run migration scripts and do not generate conflicts on github/oca pull requests.

With my proposal we may break the workflow when someone checkout pr - branches instead of stable.

One should adapt his tooling to manage modules containing a migrations/0.0.0 by doing the kind of steps (increment manifest and name the migration directory with the good version) to apply after the checkout instead of in the PR.

@legalsylvain
Copy link
Collaborator Author

I didn't understood your proposal i think.
On the meantime, i'm not sure to be agree with what i wrote 3 years ago.
Let's talk about that topic in the next oca days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Task A task the bot does or should do enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants