-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] rename migration folder #129
Comments
Sounds interesting. |
Hi, I think we can achieve it if in the merge requests we:
|
FYI @sebastienbeau |
That can not be asked to developpers. Sometimes, it is not possible to write idempotens scripts. |
I don't think migrations scripts have to be idempotants. It should allow to run migration scripts and do not generate conflicts on github/oca pull requests. With my proposal we may break the workflow when someone checkout pr - branches instead of stable. One should adapt his tooling to manage modules containing a migrations/0.0.0 by doing the kind of steps (increment manifest and name the migration directory with the good version) to apply after the checkout instead of in the PR. |
I didn't understood your proposal i think. |
When making a patch on a migration script, we have to rename the migration folder with the same name as the bumped revision. It could be automated.
I think that it could be an option of the ocabot. like
bump-migration
. the patch / minor / nobump / major is a choice of the people that are merging. (maintainers) not a choice of the developper.CC : @sbidoul : what do you think ?
Ref : OCA/server-ux#213
The text was updated successfully, but these errors were encountered: