Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run nightly main branch tasks when they have not changed #238

Open
sbidoul opened this issue May 22, 2023 · 3 comments
Open

Don't run nightly main branch tasks when they have not changed #238

sbidoul opened this issue May 22, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@sbidoul
Copy link
Member

sbidoul commented May 22, 2023

Is your feature request related to a problem?

Over time, with the number of repos and branches growing, the main branch bot is taking longer and longer.
Since it fills the queue, some more important commands wait for a long time before being executed.

Describe the solution you'd like

An "easy" optimization would be to cache the last commit processed and not re-run the main branch task if the head of the branch has not changed.

Describe alternatives you've considered

  • do nothing: not sustainable in the long run
  • investigate running main branch task with a lower priority (in the sense of the celery queues) to free workers for high priority tasks such as merge commands

Additional context

Related to #235

@sbidoul sbidoul added the enhancement New feature or request label May 22, 2023
@sbidoul
Copy link
Member Author

sbidoul commented May 23, 2023

Using redis to store the commits of the branches we have processed would be ideal.

@pedrobaeza
Copy link
Member

This morning the commands have been processed before. I thought you did something already...

@sbidoul
Copy link
Member Author

sbidoul commented May 23, 2023

This night weblate has been quiet with a much lower load on the machine, that's why the nightly bot jobs finished earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants