Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverseString - typo in comment #11

Open
phillikus opened this issue Dec 17, 2017 · 5 comments
Open

reverseString - typo in comment #11

phillikus opened this issue Dec 17, 2017 · 5 comments

Comments

@phillikus
Copy link

There seems to be a typo in AlgoCasts/exercises/reversestring/index.js:
// reverse('apple') === 'leppa'

Here the expected value should be 'elppa' instead of 'leppa'

@nathanhannig
Copy link

Why did you close this issue? I came to report same issue and since it is not fixed it should not be closed yet. Please consider re-opening; otherwise others may create a duplicate.

@phillikus
Copy link
Author

I closed it because I saw that there is already a Pull request for this: #1

@nathanhannig
Copy link

great, ideally all pull requests that fix an issue should have an open issue item and closed once the pull request is merged. I think the issue should be set to Open status still.

@phillikus
Copy link
Author

Allright then :)

@phillikus phillikus reopened this Jan 24, 2018
codedawi pushed a commit to codedawi/udemy-algo-casts that referenced this issue Apr 4, 2019
@jwarner112
Copy link

Duplicate of #1 (I know you described it already, I'm just rounding up all the duplicates for leppa)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants