Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the "edit this setting" phantom key-bindable #312

Open
FichteFoll opened this issue Nov 5, 2020 · 0 comments
Open

Make the "edit this setting" phantom key-bindable #312

FichteFoll opened this issue Nov 5, 2020 · 0 comments

Comments

@FichteFoll
Copy link
Member

With ST4, we can implement our on_navigate callback as a command and thus also allow people to bind a key to this command. To make this work properly, we would need an optional argument for the setting name (that is passed in the phantom href) with the fallback picking the setting name of the current line.

If there is no setting on the current line, we could either choose the preceding or the following setting, depending on whether the caret is inside a comment currently.

This was raised on Discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant