Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update global-actions.R documentation and filename #48

Open
4 tasks
apulsipher opened this issue Nov 19, 2024 · 0 comments
Open
4 tasks

Update global-actions.R documentation and filename #48

apulsipher opened this issue Nov 19, 2024 · 0 comments

Comments

@apulsipher
Copy link
Contributor

apulsipher commented Nov 19, 2024

  • Change filename of global-actions.R to global-events.R to match internals
  • Update documentation on add_globalevent to clearly distinguish between current and deprecated usage
  • Update rm_globalevent to take a name as the second parameter to match the underlying function call of rm_globalevent_cpp and to make the usage clearer
  • Update rm_globalevent documentation to match above changes. At the moment the documentation for add_globalevent and rm_globalevent are shared, but the usage is different enough that these should be separated
@apulsipher apulsipher changed the title Change filename of global-actions.R to global-events.R to match internals Update global-actions.R documentation and filename Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant