-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
permission
should not be a void element
#18
Comments
permission
should not use be a void elementpermission
should not be a void element
Agree. Further, I think it makes sense to have children like button etc. |
It could support 2 different forms:
Personally I like the void element better as it enforces a recognizable flow for the user. |
How about adopting the fallback content approach used by Something like this:
|
Yeah, you would absolutely need fallback for legacy user agents and any browser that doesn’t support the element. |
That fallback approach seems very appealing to me. And practically this would mean that the permission element is not a void element but rather has hard-coded user-agent-defined contents. |
Adding a new void element for HTML parsing can result in new mXSS issues. Consider e.g. https://research.securitum.com/mutation-xss-via-mathml-mutation-dompurify-2-0-17-bypass/ but instead of the
form
tags you use a<permission>
tag before<mglyph>
. Theonerror
script would now execute in browsers wherepermission
is a void element (assuming a sanitizer that allowsmath
).There might be other similar cases; generally, changes to the HTML parser carry some XSS risk.
I would suggest no changes to the HTML parser here. Require the end tag.
The text was updated successfully, but these errors were encountered: