Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists.txt points at missing file #17

Open
JayFoxRox opened this issue Dec 18, 2019 · 0 comments
Open

CMakeLists.txt points at missing file #17

JayFoxRox opened this issue Dec 18, 2019 · 0 comments

Comments

@JayFoxRox
Copy link
Member

JayFoxRox commented Dec 18, 2019

18e3b16 introduced a bug which breaks CMake (which was added later in 4246158); this prevents running tests on non-Xbox platforms.

$ mkdir build
$ cd build
$ cmake ..
++ CMAKE_BUILD_TYPE not set. Defaulting to 'Debug'.
-- Configuring done
CMake Error at CMakeLists.txt:309 (add_library):
  Cannot find source file:

    functions/_PDCLIB/assert.c

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
  .hpp .hxx .in .txx

[...]

I'm not sure how to resolve this most gracefully.

Generally it feels like 18e3b16 shouldn't require changes to existing pdclib code. We have extension hooks now and there has always been the optimization overlay (which works as long as we don't use wildcards in our Makefiles).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant