EphemeralRunner status.ready should reflect Pod readiness

[ordovicia]

Checks

• I've already read https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/troubleshooting-actions-runner-controller-errors and I'm sure my issue is not covered in the troubleshooting guide.
• I am using charts that are officially provided

Controller Version

0.9.3

Deployment Method

Other

Checks

• This isn't a question or user support case (For Q&A and community support, go to Discussions).
• I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes

To Reproduce

N/A

Describe the bug

EphemeralRunner's readiness (status.ready field) is calculated as follows.
It becomes true when the associated Pod starts running (status.phase: Running).

actions-runner-controller/controllers/actions.github.com/ephemeralrunner_controller.go

Line 701 in 8b36ea9

obj.Status.Ready = obj.Status.Ready || (pod.Status.Phase == corev1.PodRunning)

However, EphemeralRunner's readiness should reflect the Pod's readiness (status.conditions[type="Ready"].status).
Otherwise, an EphemeralRunner is recognized as ready while its Pod is actually not ready yet.

Describe the expected behavior

EphemeralRunners become ready once their associated Pods become ready, not just running.

Additional Context

N/A

Controller Logs

N/A

Runner Pod Logs

N/A

[github-actions]

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.