-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: set Azure Tags on Packer VM #10883
Comments
Hi @baidarka , We're looking into your issue , thank you ! |
PR #10884 |
This would be a nice addition! |
Hi |
Hi We request that you give further information or justification to consider it. |
SummaryWe would like to take advantage of the 'azure_tags' parameter in the Packer templates, for instance here: while using the build-image.ps1 script; about here: Please note that these 'azure_tags' are only applied to the temporary Packer VM in Azure, which is used to build an Azure and/or GitHub runner image and subsequently deleted by Packer. QuestionI am not sure what you mean by: 'Packer templates can contain the parameter 'azure_tags to include with many''? ScenarioAs a team we provide, amongst others, VM images for self-hosted runners for our organization. ProblemDue to internal policies, we cannot just-spin-up-a-VM, let alone a temporary VM downloading a bunch of tooling (even if this takes place in isolation) Besides, earlier discussions like #discussioncomment-4591809 within this project may benefit from the proposed PR #10884 . |
Would it be helpful if I provide additional information? If yes, what would you be looking for? Looking forward to your insights! |
Hi @baidarka Please share your thoughts. |
Dear @lakshminarayana02, The requested feature (and PR) are not aimed at OS image creation nor at azure policy definitions, nor security posture. Existing parameter: This template parameter is not used nor exposed in build-image.ps1. This does not affect the image to be build. It affects the temporary Packer VM used to build the image. |
Description
Feature request: extra parameter on 'build-image.ps1' script so that Azure tags can be passed along to the temporary Packer VM resource.
Although the Packer templates support the parameter 'azure_tags', the build script 'build-image.ps1' does not support that parameter. It is not possible to set Azure tags on the Packer VM when using 'build-image.ps1' or the Azure pipelines in this repo.
(this is an issue, not a bug; apologies, i could not find a matching issue format)
Implemented in PR #10884
Platforms affected
Runner images affected
Image version and build link
I need to set Azure tags on the temporary Packer VM that build the image.
Is it regression?
No
Expected behavior
Have a parameter on the build-image.ps1 script to pass on Azure tags to the Packer template file.
Actual behavior
No such parameter.
Repro steps
No such parameter.
The text was updated successfully, but these errors were encountered: