Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable setting up of go on ppc64/ppc64le systems. #518

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable setting up of go on ppc64/ppc64le systems. #518

wants to merge 1 commit into from

Conversation

kishen-v
Copy link

@kishen-v kishen-v commented Nov 25, 2024 •
edited
Loading

Description:
This change enables to install go on ppc64/ppc64le systems based on endianness.
The existing flow tends to pick ppc64 bundle for both big endian/little endian machines as os.arch() does not have the capability to determine the endianness, which leads to installing an unsupported bundle in the case of ppc64le.

Related issue:
Fixes #517

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.
 go-version-file
      ✓ reads version from go.mod (1 ms)
      ✓ reads version from go.work (1 ms)
      ✓ reads version from .go-version (1 ms)
      ✓ is overwritten by go-version
      ✓ reports a read failure
      ✓ acquires specified architecture of go (2 ms)
      ✓ acquires latest go version with stable go-version input
      ✓ acquires latest go version with oldstable go-version input
      ✓ should return ppc64 when architecture is ppc64 and system is Big Endian <-----
      ✓ should return ppc64le when architecture is ppc64 and system is Little Endian <-----

---------------------|---------|----------|---------|---------|---------------------------------------------------
File                 | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                                 
---------------------|---------|----------|---------|---------|---------------------------------------------------
All files            |    87.5 |    82.35 |   91.83 |    87.4 |                                                   
 cache-restore.ts    |   81.57 |    57.14 |   66.66 |   81.08 | 54-65                                             
 cache-utils.ts      |     100 |      100 |     100 |     100 |                                                   
 constants.ts        |     100 |      100 |     100 |     100 |                                                   
 installer.ts        |   82.41 |    81.01 |      88 |   82.56 | 55-57,113,182,187-220,343,381-385,413,435-459,474 
 main.ts             |   92.94 |    78.26 |     100 |   92.94 | 56,68-77                                          
 package-managers.ts |     100 |      100 |     100 |     100 |                                                   
 system.ts           |   89.47 |    85.71 |     100 |   89.47 | 41-42                                             
 utils.ts            |     100 |      100 |     100 |     100 |                                                   
---------------------|---------|----------|---------|---------|---------------------------------------------------
Test Suites: 4 passed, 4 total
Tests:       72 passed, 72 total
Snapshots:   0 total
Time:        2.795 s
Ran all test suites.

@kishen-v kishen-v requested a review from a team as a code owner November 25, 2024 05:18
@kishen-v kishen-v mentioned this pull request Nov 25, 2024
Open
@kishen-v kishen-v force-pushed the ppc64le branch 3 times, most recently from 00beeea to 9474567 Compare November 26, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable installation of go on ppc64/ppc64le systems
1 participant
@kishen-v