Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: config support profile and multiple values (#3552) #3553

Open
wants to merge 2 commits into
base: 2021.x
Choose a base branch
from

Conversation

wangYX657211334
Copy link

'spring.config.import with nacos' support profile and multiple values

Describe what this PR does / why we need it

Keep consistent with spring boot config resolver behavior

Does this pull request fix one issue?

#3552

Describe how you did it

modify com.alibaba.cloud.nacos.configdata.NacosConfigDataLocationResolver

  1. each location splice profile
  2. each location spilt

Describe how to verify it

#3552

Special notes for reviews

'spring.config.import with nacos' support profile and multiple values
@CLAassistant
Copy link

CLAassistant commented Dec 22, 2023

CLA assistant check
All committers have signed the CLA.

@gebing
Copy link

gebing commented Mar 15, 2024

that's the wanted feature, pls merge ASAP

@shiyiyue1102
Copy link
Contributor

We recommend specifying the specific dataId and group directly through spring.config.import. If you need to specify a profile, we suggest using a ${} placeholder in the dataId, such as spring.cnfig.import=nacos: application-${profile}. yml&group=mygroup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants