Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Connect Client break between version 3.696.0 and 3.699.0 #6695

Open
4 tasks done
zyrorl opened this issue Nov 26, 2024 · 1 comment
Open
4 tasks done

Amazon Connect Client break between version 3.696.0 and 3.699.0 #6695

zyrorl opened this issue Nov 26, 2024 · 1 comment
Labels
bug This issue is a bug. p2 This is a standard priority issue response-requested Waiting on additional info and feedback. Will move to \"closing-soon\" in 7 days.

Comments

@zyrorl
Copy link

zyrorl commented Nov 26, 2024

Checkboxes for prior research

Describe the bug

The interface for ListRoutingProfilesCommandOutput has broken, and is now missing the RoutingProfileSummaryList attribute in the api.

Regression Issue

  • Select this option if this issue appears to be a regression.

SDK version number

@aws-sdk/[email protected]

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

v22.10.0

Reproduction Steps

Observed Behavior

Expected Behavior

Possible Solution

downgrade to version 3.696.0

Additional Information/Context

No response

@zyrorl zyrorl added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 26, 2024
@github-actions github-actions bot added potential-regression Marking this issue as a potential regression to be checked by team member and removed potential-regression Marking this issue as a potential regression to be checked by team member labels Nov 26, 2024
@RanVaknin
Copy link
Contributor

Hi @zyrorl ,

I'm not sure why you are seeing a breaking change. I dont see a change in interface:

import {ListRoutingProfilesCommandOutput, ListRoutingProfilesCommand, ConnectClient} from '@aws-sdk/client-connect'

const client = new ConnectClient({
  region: "us-east-1"
})

async function run(){
  try {
    const command = new ListRoutingProfilesCommand({
      InstanceId: "REDACTED",
    });
  
    const response: ListRoutingProfilesCommandOutput = await client.send(command);
  
    console.log(response.RoutingProfileSummaryList);
  
    if (response.RoutingProfileSummaryList) {
      response.RoutingProfileSummaryList.forEach(profile => {
        console.log(profile.Name);
        console.log(profile.Arn);
      });
    }
  
  } catch (error) {
    console.error(error);
  }
}

run()
  

results in:

$ npm ls
[email protected] /Users/rvaknin/test_folder/connect-try
└── @aws-sdk/[email protected]

$ tsc sample.ts 
$ node sample.js
[
  {
    Arn: 'arn:aws:connect:us-east-1:REDACTED:instance/REDACTED/routing-profile/REDACTED',
    Id: 'REDACTED',
    LastModifiedRegion: 'us-east-1',
    LastModifiedTime: 2024-05-17T04:48:07.110Z,
    Name: 'Basic Routing Profile'
  }
]
Basic Routing Profile
arn:aws:connect:us-east-1:REDACTED:instance/REDACTED/routing-profile/REDACTED

The only change I see is this a83926c#diff-164fa22f7a2439af11297a84706a2efd3c0be36a3d5f92ab06e16c9436646e00L3

Which changed the imports to new model file which has the RoutingProfileSummaryList in question.

If I had to guess what happened is that your project has multiple versions of the same @aws-sdk/client-connect dependency. You can check that by running:

$ npm ls -a @aws-sdk/client-connect

and then see the dependency tree to make sure all of them point to the latest 3.699.0 by using npm dedupe, or by deleting your node_modules and pacakge-lock.json and running npm install again.

Let me know if this helped.
All the best,
Ran~

@RanVaknin RanVaknin added response-requested Waiting on additional info and feedback. Will move to \"closing-soon\" in 7 days. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue response-requested Waiting on additional info and feedback. Will move to \"closing-soon\" in 7 days.
Projects
None yet
Development

No branches or pull requests

2 participants