Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqlite: check anchor to tx foreign key constraint #1712

Open
notmandatory opened this issue Nov 14, 2024 · 3 comments · May be fixed by #1736
Open

Sqlite: check anchor to tx foreign key constraint #1712

notmandatory opened this issue Nov 14, 2024 · 3 comments · May be fixed by #1736
Labels
audit Suggested as result of external code audit module-database
Milestone
1.0.0-beta

Comments

@notmandatory
Copy link
Member

"In the SQLite persistence the foreign key constraint from anchor to transactions is not checked. Adding an anchor for a non-existing transaction will prevent persisting the wallet."
@notmandatory notmandatory added audit Suggested as result of external code audit module-database labels Nov 14, 2024
@notmandatory notmandatory added this to BDK Nov 14, 2024
@notmandatory notmandatory moved this to Todo in BDK Nov 14, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Nov 14, 2024
@notmandatory
Copy link
Member Author

Is there a scenario where were need to insert an Anchor without a corresponding transaction id?

@ValuedMammal
Copy link
Contributor

ValuedMammal commented Nov 20, 2024 •
edited
Loading

We should also revisit #961 when trying to reproduce the SQL error.

@notmandatory notmandatory mentioned this issue Nov 21, 2024
Open
3 tasks
@notmandatory
Copy link
Member Author

notmandatory commented Nov 21, 2024 •
edited
Loading

@oleonardolima is taking a look at this one. Or possibly just helping with testing @evanlinjin's PR #1736.

@ValuedMammal ValuedMammal linked a pull request Nov 26, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit Suggested as result of external code audit module-database
Projects
BDK
Status: Needs Review
Milestone
1.0.0-beta
Development

Successfully merging a pull request may close this issue.

Sqlite - allow persisting anchor without tx evanlinjin/bdk
2 participants
@notmandatory @ValuedMammal