Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paparazzi record all snapshots again #1597

Open
M0hammed opened this issue Sep 22, 2024 · 2 comments
Open

Paparazzi record all snapshots again #1597

M0hammed opened this issue Sep 22, 2024 · 2 comments
Labels
bug Something isn't working waiting on user Waiting on information from OP

Comments

@M0hammed
Copy link

Description

After updating Paparazzi from v1.3.1 to v1.3.4 to address OutOfMemory (OOM) errors, a significant number of tests started failing, while using maxPercentDifference: Double = 0.1. Running the ./gradlew recordPaparazziDebug command regenerated all snapshots, despite no changes in the codebase.

Steps to Reproduce

  • Update Paparazzi to v1.3.4.
  • Run ./gradlew verifyPaparazziDebug.
  • Observe that many tests fail unexpectedly.
  • Run ./gradlew recordPaparazziDebug.
  • Notice that all snapshots are regenerated, even though no code changes were made.

Expected Behavior

  • The tests should pass without regenerating snapshots unnecessarily. If there are no changes in the code, Paparazzi should load - snapshots from the cache instead of regenerating them.

Additional Information

Paparazzi Version: 1.3.4
OS: macOS
Compile SDK: 34
Gradle Version: 8.9
Android Gradle Plugin Version: 8.5.1

@M0hammed M0hammed added the bug Something isn't working label Sep 22, 2024
@geoff-powell
Copy link
Collaborator

Version 1.3.4 had some known changes in rendering which unfortunately would require some snapshot regen. @jrodbx was able to diagnose this change and fix it . Once our next version is out, it should fix this issue. If you want to try the latest and greatest, try using the 1.3.5-SNAPSHOT version.

@geoff-powell geoff-powell added the waiting on user Waiting on information from OP label Sep 23, 2024
@nicbell
Copy link
Contributor

nicbell commented Nov 14, 2024

You do have to re-record snapshots if there are significant changes to layoutlib. Same as how previews sometimes look a bit different / better after upgrading Android Studio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting on user Waiting on information from OP
Projects
None yet
Development

No branches or pull requests

3 participants