Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent Payment scanning [suggestion] #257

Open
thisIsNotTheFoxUrLookingFor opened this issue Aug 24, 2024 · 7 comments
Open

Silent Payment scanning [suggestion] #257

thisIsNotTheFoxUrLookingFor opened this issue Aug 24, 2024 · 7 comments
Labels
BTC Related to Bitcoin BTC & Bitcoin Core enhancement New feature or request

Comments

@thisIsNotTheFoxUrLookingFor

Cake Wallet appear to have made a WIP fork of electrs to scan for the new Bitcoin Silent Payments (https://silentpayments.xyz/docs/developers/).

Is there any plans for Fulcrum to provide this scanning? it would be really useful, I could connect my cake wallet to my Fulcrum for this purpose then!

@cculianu
Copy link
Owner

cculianu commented Aug 24, 2024

We have something similar in Bitcoin Cash. I was not aware that people are moving forward with the silent payment stuff in BTC. I can look into it and offer that as an index on Core nodes... yeah. If I have time.

I might ask for a fundraiser for this. Hmm. Thanks for alerting me to its existence.

@cculianu cculianu added enhancement New feature or request BTC Related to Bitcoin BTC & Bitcoin Core labels Aug 24, 2024
@cculianu
Copy link
Owner

cculianu commented Aug 29, 2024

Random thoughts:

I've been investigating it and the way it works on Core is a little complex. Actually the easiest implementation would be just to pass off the calls to bitcoind -- if Core merges that PR for the optional silent payment index + RPC. But I suspect most nodes won't have a patched bitcoind with that index + RPC enabled so that may be a no-go.

But barring that I can "reproduce" the index in Fulcrum .. will require some time for me to work on this -- since the implementation of silent payments on BTC is a little complex. Perhaps the earliest I can have something out would be late September.. if if if I get time to work on it.

I'll have to see what the electrs fork is doing, whether they are just relying on bitcoind being patched with that index or if they are reimplementing the same facility for that indexing PR .. inside electrs...

@thisIsNotTheFoxUrLookingFor
Copy link
Author

thisIsNotTheFoxUrLookingFor commented Aug 30, 2024

@cculianu nothing wrong with that idea, silentpayments is new so people really need to be running a new bitcoind for it anyway. I think the index you are referring to is the COMPACT_BLOCK_FILTERS one, I have that enabled in my bitcoind 27.0.1

Ah wait actually is there a specific index that is not yet in the base of core? I guess I won't have it then

@cculianu
Copy link
Owner

Oh.. actually I'm referring to this: bitcoin/bitcoin#28241

It's a new rpc (backed by an index) called getsilentpaymentblockdata which does the brunt of the work, really.

@thisIsNotTheFoxUrLookingFor
Copy link
Author

thisIsNotTheFoxUrLookingFor commented Aug 30, 2024

Oh.. actually I'm referring to this: bitcoin/bitcoin#28241

It's a new rpc (backed by an index) called getsilentpaymentblockdata which does the brunt of the work, really.

Yah ended up finding it. I wonder if they will impliment it? It makes sense for bitcoind to track the index because it is not a light wallet only feature, in theory the GUI that ships with bitcoind should support it as well, so really their RPC should expose it yea.

@cculianu
Copy link
Owner

I'd be surprised if they merge this anytime soon.. but who knows. I do agree it's a nice feature for the node.

@ottosch
Copy link

ottosch commented Sep 25, 2024

@cculianu you might want to take a look the blindbit-oracle implementation. It receives the blocks and does the tweaks calculations (there's a list of endpoints if you scroll down).

I have written a text called How Silent Payments Work with a demonstration.

It seems to me Fulcrum could do all the calculation for the wallet, if the keys are added to it. Since there are 2 private keys and only 1 is needed to scan, it seems this could work very well (at least on a personal Fulcrum).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BTC Related to Bitcoin BTC & Bitcoin Core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants