Skip to content

Latest commit

 

History

History
135 lines (100 loc) · 5.26 KB

CONTRIBUTING.md

File metadata and controls

135 lines (100 loc) · 5.26 KB
Raw

Contributing

Architecture

When the Coder Remote plugin handles a request to open a workspace, it invokes Microsoft's Remote - SSH extension using the following URI structure:

vscode://ssh-remote+<hostname><path>

The ssh-remote scheme is registered by Microsoft's Remote - SSH extension and indicates that it should connect to the provided host name using SSH.

The host name takes the format coder-vscode.<domain>--<username>--<workspace>. This is parsed by the CLI (which is invoked via SSH's ProxyCommand) to route SSH to the right workspace.

The Coder Remote extension also registers for the onResolveRemoteAuthority:ssh-remote extension activation event to hook into this process, running before the Remote - SSH extension actually connects.

On activation of this event, we check if vscode.workspace.workspaceFolders contains the coder-vscode prefix, and if so we delay activation to:

  1. Parse the host name to get the domain, username, and workspace.
  2. Ensure the workspace is running.
  3. Download the matching server binary to the client.
  4. Configure the binary with the URL and token, asking the user for them if they are missing. Each domain gets its own config directory.
  5. Add an entry to the user's SSH config for coder-vscode.<domain>--*.
Host coder-vscode.dev.coder.com--*
	ProxyCommand "/tmp/coder" vscodessh --network-info-dir "/home/kyle/.config/Code/User/globalStorage/coder.coder-remote/net" --session-token-file "/home/kyle/.config/Code/User/globalStorage/coder.coder-remote/dev.coder.com/session_token" --url-file "/home/kyle/.config/Code/User/globalStorage/coder.coder-remote/dev.coder.com/url" %h
	ConnectTimeout 0
	StrictHostKeyChecking no
	UserKnownHostsFile /dev/null
	LogLevel ERROR

If any step fails, we show an error message. Once the error message is closed we close the remote so the Remote - SSH connection does not continue to connection. Otherwise, we yield, which lets the Remote - SSH continue.

VS Code SSH uses the ssh -D <port> flag to start a SOCKS server on the specified port. This port is printed to the Remote - SSH log file in the VS Code Output panel in the format -> socksPort <port> ->. We use this port to find the SSH process ID that is being used by the remote session.

The vscodessh subcommand on the coder binary periodically flushes its network information to network-info-dir + "/" + process.ppid. SSH executes ProxyCommand, which means the process.ppid will always be the matching SSH command.

Coder Remote periodically reads the network-info-dir + "/" + matchingSSHPID file to display network information.

Other features

There is a sidebar that shows all the user's workspaces, and all users' workspaces if the user has the required permissions.

There are also notifications for an outdated workspace and for workspaces that are close to shutting down.

Testing

There are a few ways you can test the "Open in VS Code" flow:

  • Use the "VS Code Desktop" button from a Coder dashboard.
  • Manually open the link with Developer: Open URL from inside VS Code.
  • Use code --open-url on the command line.

The link format is vscode://coder.coder-remote/open?${query}. For example:

code --open-url 'vscode://coder.coder-remote/open?url=dev.coder.com&owner=my-username&workspace=my-ws&agent=my-agent'

There are some unit tests as well:

yarn test

Note that we have an unusual testing setup with vitest; this needs to be changed back to how using the standard testing framework for VS Code extensions was but for now it means some things are difficult to test as you cannot import vscode in tests or write any UI tests.

Development

Important

Reasoning about networking gets really wonky trying to develop this extension from a coder workspace. We currently recommend cloning the repo locally

  1. Run yarn watch in the background.

  2. OPTIONAL: Compile the coder binary and place it in the equivalent of os.tmpdir() + "/coder". If this is missing, it will download the binary from the Coder deployment, as it normally would. Reading from /tmp/coder is only done in development mode.

    On Linux or Mac:

    # Inside https://github.com/coder/coder
$ go build -o /tmp/coder ./cmd/coder

  3. Press F5 or navigate to the "Run and Debug" tab of VS Code and click "Run Extension".

  4. If your change is something users ought to be aware of, add an entry in the changelog.

Dependencies

Some dependencies are not directly used in the source but are required anyway.

  • bufferutil and utf-8-validate are peer dependencies of ws.
  • ua-parser-js and dayjs are used by the Coder API client.
  • glob, nyc, vscode-test, and @vscode/test-electron are currently unused but we need to switch back to them from vitest.

Releasing

  1. Check that the changelog lists all the important changes.
  2. Update the package.json version and add a version heading to the changelog.
  3. Push a tag matching the new package.json version.
  4. Update the resulting draft release with the changelog contents.
  5. Publish the draft release.
  6. Download the .vsix file from the release and upload to the marketplace.