Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Not compatible with the latest Ray/Pytorch-Lightning versions #47

Open
sunhwan opened this issue Apr 20, 2023 · 1 comment
Open
Labels
bug Something isn't working

Comments

@sunhwan
Copy link
Contributor

sunhwan commented Apr 20, 2023

Describe the bug
If the package is installed by following the instruction on README.md, the main CLI script fails to run due to incompatibility to ray and pytorch-lightning version as of Apr. 2023. I suspect there has been a major version change in both Ray and Pytorch-lightning.

I fixed this by pinning pytorch-lightning and ray narrowly in the environment.yml file.

name: molpal

channels:
  - nvidia
  - pytorch
  - conda-forge
  - defaults

dependencies:
  - python=3.9
  - pytorch=1.13.1
  - pytorch-cuda=11.7
  - pip
  - pip:
    - configargparse
    - h5py
    - numpy
    - ray >= 1.11,<2.0
    - ray[tune]
    - rdkit
    - pytorch-lightning == 1.5.10
    - scikit-learn
    - tensorflow
    - tensorflow-addons
    - tqdm
@sunhwan sunhwan added the bug Something isn't working label Apr 20, 2023
@DavidSchallerNuvisan
Copy link

Thanks so much for the updated environment.

We additionally identified a GPU memory issue with the required ray version (29624).

With every iteration the GPU memory increases when using MPNN as model. One can prevent this with @ray.remote(max_calls=1) at L92).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants