-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abort builds with [skip ci]/etc #629
Comments
Not a big deal IMO, the advantages do outweigh this disadvantage. I'm not sure how hard would be to implement that but I like the idea of a |
I think all we need to do is have the build script run a |
This will become even more interesting once we switch to azure as the provider for many platforms. |
Any update on this? Skipping CI for Azure does not seem to work. |
I added:
With those merged and released we can close this. |
Even though CircleCI supposedly supports
[skip ci]
, I still usually see builds go through when I add that; not sure what I'm doing wrong, if they dropped it, or if something is misconfigured on our end. But we could work around that by changing the build scripts, or maybeff_ci_pr_build.py
, to check the commit message and abort if it sees[skip ci]
.Also, since CircleCI doesn't support
[skip circle]
and don't seem to want to (#45 (comment)), we could more-or-less implement that here. Same for[skip travis]
(travis-ci/travis-ci#5032). Or we could implement[skip mac]
or something to still work when we use CircleCI for Mac builds also, or similar.Drawback: it would prevent you from manually running builds of commits that shouldn't actually have been skipped, unless we add something to do that.
The text was updated successfully, but these errors were encountered: