Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo creusot rebuilds too much if any RUSTFLAGS argument changes #1218

Open
Lysxia opened this issue Nov 4, 2024 · 1 comment
Open

cargo creusot rebuilds too much if any RUSTFLAGS argument changes #1218

Lysxia opened this issue Nov 4, 2024 · 1 comment
Labels
cargo-creusot Issue is related to the `cargo-creusot` and more generally the porcelain around creusot

Comments

@Lysxia
Copy link
Collaborator

Lysxia commented Nov 4, 2024

Issue first noticed here: #1212 (comment)

cargo creusot and cargo creusot --monolithic make each other rebuild everything including dependencies, even though the flag --monolithic should only affect the current package. The problem is that we are passing options in RUSTFLAGS which applies even to build dependencies. Previously (#1207) we had the opposite problem where cargo did not see the arguments that changed at all, so it did nothing at all when adding/removing --monolithic or any other creusot-rustc argument.

We need a more fine grained way than RUSTFLAGS to pass argument to creusot-rustc.

@Lysxia Lysxia changed the title cargo creusot rebuilds too much cargo creusot rebuilds too much if any RUSTFLAGS argument changes Nov 4, 2024
@Lysxia Lysxia added the cargo-creusot Issue is related to the `cargo-creusot` and more generally the porcelain around creusot label Nov 4, 2024
@xldenis
Copy link
Collaborator

xldenis commented Nov 4, 2024

Yea, changing RUSTFLAGS (correctly) causes cargo to rebuild everything. We definitely need to pass arguments through another mechanism, but then that re-introduces the stale detection issues with cargo. it might be worth asking on zulip / irlo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cargo-creusot Issue is related to the `cargo-creusot` and more generally the porcelain around creusot
Projects
None yet
Development

No branches or pull requests

2 participants