Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Filter Value Lookups #21

Open
d3an opened this issue Aug 29, 2020 · 0 comments
Open

Improve Filter Value Lookups #21

d3an opened this issue Aug 29, 2020 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@d3an
Copy link
Owner

d3an commented Aug 29, 2020

The FilterValueLookup covers all 70 filter types and their corresponding values. The dictionary needs to be fixed up so that each value perfectly mirrors that provided on the site. Once this step is completed, shortcuts should be added as well. Consider the Market Cap filter. A possible shortcut for Mega ($200bln and more) could just be mega.

As a bonus task, consider adding support for approximate string matching. Take a look at the Levenshtein distance metric and see how others have implemented this technique in their projects.

@d3an d3an added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 29, 2020
@d3an d3an removed the good first issue Good for newcomers label Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant