Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider supporting nerdctl+containerd? #1232

Open
tianyax opened this issue Feb 15, 2023 · 10 comments · May be fixed by #1248
Open

consider supporting nerdctl+containerd? #1232

tianyax opened this issue Feb 15, 2023 · 10 comments · May be fixed by #1248
Assignees
Labels
area/cli kind/enhancement enhancement to an existing feature kind/proposal A new proposal to be considered P2 question Further information is requested triaged/resolved The issue has been triaged

Comments

@tianyax
Copy link
Contributor

tianyax commented Feb 15, 2023

Describe the proposal

My development environment uses nerdctl+containerd instead of docker, which makes dapr cli not work on my environment. Will containerd be added as a container runtime? I'd love to try and contribute a PR if this is possible.

daprcli

Release Note

RELEASE NOTE:

@tianyax tianyax added the kind/proposal A new proposal to be considered label Feb 15, 2023
@pravinpushkar
Copy link
Contributor

pravinpushkar commented Feb 15, 2023

@tianyax Sure, feel free to send a PR. @mukundansundar @yaron2 any thoughts on this proposal ?

@mukundansundar
Copy link
Collaborator

@tianyax Please feel free to contribute a PR for this feature.

@mukundansundar mukundansundar added area/cli P2 size/S 1 week of work triaged/resolved The issue has been triaged kind/enhancement enhancement to an existing feature labels Feb 15, 2023
@mukundansundar
Copy link
Collaborator

@tianyax If you are working on this please comment /assign on this issue

@tianyax
Copy link
Contributor Author

tianyax commented Feb 15, 2023

/assign

@mukundansundar
Copy link
Collaborator

mukundansundar commented Feb 15, 2023

@tianyax There are a some questions that I have ...

  • Does nerdctl support all commands that docker supports?
  • Is there a plan to maintain compatibility with docker command similar to podman?
  • Is there a nerdctl go library available that can be used instead of the command directly? And if so can that be used for nerdctl?
  • Is is there windows support for containerd and nerdctl?
  • What sort of documentation and support is needed for nerdctl when used with dapr?

These questions would help clarify adding support and documentation in the dapr CLI.

@mukundansundar mukundansundar added triaged/unresolved Issue has been triaged but has unresolved issues yet. question Further information is requested and removed triaged/resolved The issue has been triaged size/S 1 week of work labels Feb 15, 2023
@tianyax
Copy link
Contributor Author

tianyax commented Feb 15, 2023

@tianyax There are a some questions that I have ...

  • Does nerdctl support all commands that docker supports?
  • Is there a plan to maintain compatibility with docker command similar to podman?
  • Is there a nerdctl go library available that can be used instead of the command directly? And if so can that be used for nerdctl?
  • Is is there windows support for containerd and nerdctl?
  • What sort of documentation and support is needed for nerdctl when used with dapr?

These questions would help clarify adding support and documentation in the dapr CLI.

@mukundansundar
For 1,2,5:
nerdctl is a Docker-compatible containerd CLI, and as far as I know it will always be compatible, the community is active (maybe I'll contribute a PR fix if there are some incompatibilities), many users often use alias docker=nerdctl for a consistent experience with docker, so we probably don't need additional documentation(some environment variables may be excluded).
For 4:
nerdctl and containerd are supported by windows, but I haven’t actually used it. I need to verify the integrity of the function on windows,but macos does not support containerd and nerdctl.
For 3:
nerdctl go library? I don't see this at the moment, maybe we can use the nerdctl project directly. If the function is simple, is it better to reduce the import of packages?

@tianyax
Copy link
Contributor Author

tianyax commented Feb 16, 2023

@mukundansundar Sorry, the --network-alias parameter is not supported when nerdctl run the container, I will try to fix it, this feature may need to be delayed..

tianyax added a commit to tianyax/cli that referenced this issue Feb 24, 2023
tianyax added a commit to tianyax/cli that referenced this issue Feb 24, 2023
tianyax added a commit to tianyax/cli that referenced this issue Feb 24, 2023
tianyax added a commit to tianyax/cli that referenced this issue Feb 24, 2023
tianyax added a commit to tianyax/cli that referenced this issue Feb 24, 2023
tianyax added a commit to tianyax/cli that referenced this issue Feb 25, 2023
tianyax added a commit to tianyax/cli that referenced this issue Feb 25, 2023
tianyax added a commit to tianyax/cli that referenced this issue Feb 25, 2023
@tianyax tianyax linked a pull request Feb 27, 2023 that will close this issue
3 tasks
@pravinpushkar
Copy link
Contributor

@tianyax Is it possible to use containerd with https://github.com/abiosoft/colima or with Rancher desktop on Macos ?

@tianyax
Copy link
Contributor Author

tianyax commented Feb 28, 2023

@tianyax Is it possible to use containerd with https://github.com/abiosoft/colima or with Rancher desktop on Macos ?

@pravinpushkar colima and rancher-desktop both use lima, which implements containerd support on mac by starting a qemu vm and using the containerd runtime inside it. which makes me think it's not a supported runtime on the mac itself, so I filtered it out. But this should be supported, I will test it later.

@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Mar 30, 2023
@mukundansundar mukundansundar added triaged/resolved The issue has been triaged and removed triaged/unresolved Issue has been triaged but has unresolved issues yet. stale labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli kind/enhancement enhancement to an existing feature kind/proposal A new proposal to be considered P2 question Further information is requested triaged/resolved The issue has been triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants