Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: User-configurable Base Href in helm deployment #178

Open
lisy09 opened this issue Nov 13, 2021 · 1 comment
Open

Dashboard: User-configurable Base Href in helm deployment #178

lisy09 opened this issue Nov 13, 2021 · 1 comment

Comments

@lisy09
Copy link

lisy09 commented Nov 13, 2021

Describe the proposal

As #168 provides the approach to configurate base href for dapr-dashboard, it is better to make this base href configurable also in helm based deployment.

modify: https://github.com/dapr/dapr/blob/master/charts/dapr/charts/dapr_dashboard/templates/dapr_dashboard_deployment.yaml

from:

...

        env:
        - name: NAMESPACE
          valueFrom:
            fieldRef:
              fieldPath: metadata.namespace
...

to:

...

        env:
        - name: NAMESPACE
          valueFrom:
            fieldRef:
              fieldPath: metadata.namespace
{{- if .Values.env.basehref }}
        - name: SERVER_BASE_HREF
           value: {{ .Values.env.basehref }}
{{- end }}
...
@yaron2
Copy link
Member

yaron2 commented Dec 23, 2021

Would you be willing to open a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants