Skip to content
This repository has been archived by the owner on Apr 17, 2018. It is now read-only.

Model.find is useless #1

Open
knowtheory opened this issue May 9, 2010 · 2 comments
Open

Model.find is useless #1

knowtheory opened this issue May 9, 2010 · 2 comments

Comments

@knowtheory
Copy link
Member

Model.find only takes one of 4 arguments right now: an id, :first, :last, or :all. If passed another argument (such as a hash), it simply returns nil.

The find method should either throw an error if it doesn't get it's expected input, or it should be expanded to map more of ActiveRecord's finder syntax onto DataMapper.

@dkubb
Copy link
Member

dkubb commented May 9, 2010

I would vote for throwing an exception now, then looking to extend the finder syntax later.

@knowtheory
Copy link
Member Author

That's my preference!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants