Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HashLoader color is taken from the last HashLoader component #581

Open
Legend999 opened this issue Mar 16, 2024 · 1 comment · Fixed by #602
Open

HashLoader color is taken from the last HashLoader component #581

Legend999 opened this issue Mar 16, 2024 · 1 comment · Fixed by #602
Labels

Comments

@Legend999
Copy link

Package Version
0.13.8

Describe the bug
HashLoader color is taken from the last HashLoader component. If we have 2 HashLoaders with different assigned colors, they will have the color of the last one.

In the following case, both loaders will be green:

<HashLoader color="red" />
<HashLoader color="green" />

To Reproduce
https://codesandbox.io/p/devbox/lucid-tom-vql768-forked-zcnzjh

Expected behavior
The first loader should be red and the second one should be green.

Screenshots
image

@davidhu2000
Copy link
Owner

had to revert this change since it breaks SSR + jest snapshots. Will need to think about how to do this better. maybe including the color as part of the animation name make sense, something deterministic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants