Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: Should we enable AppVeyor (Windows CI) for all repos? #13

Open
wilzbach opened this issue May 20, 2017 · 6 comments
Open

Q: Should we enable AppVeyor (Windows CI) for all repos? #13

wilzbach opened this issue May 20, 2017 · 6 comments
Labels

Comments

@wilzbach
Copy link
Member

What do you think about adding a Windows CI to our common standards (#7) for all repositories?
I personally haven't used Windows for years, but I do realize that it's a very important target and usually a bit neglected in the D community.

However, it's quite easy to add such a config and I made an Proof-of-Concept (PoC) one to libdparse: dlang-community/libdparse#141

@ghost
Copy link

ghost commented May 21, 2017

If this allows to keep the build.bat in sync with the other builds i'm in favor. Make or build.bat or dub.json being broken is a recurrent issue. Also good because of the 32 bit build. In the past there's occasionally been size_t vs ulong errors.

@ghost ghost added the question label May 21, 2017
@ghost
Copy link

ghost commented Jun 11, 2017

I've merged too fast yesterday. Actuallt it seems that all the bigger projects have issues: for example look at this:

@ghost
Copy link

ghost commented Jun 11, 2017

I'm sorry but AppVeyor doesn't seem reliable enough. There are some random failures. They will annoy everybody when serious pull requests will come so i think we should revert what's been already merged.

@wilzbach
Copy link
Member Author

I've merged too fast yesterday. Actuallt it seems that all the bigger projects have issues: for example look at this:

Hmm this seems to be an issue with Dub on Windows not AppVeyor ...

I'm sorry but AppVeyor doesn't seem reliable enough. There are some random failures. They will annoy everybody when serious pull requests will come so i think we should revert what's been already merged.

Can we simply disable the webhook? If Dub/Dub-registry issues gets fixed, we don't have to adjust the scripts anyway (or maybe only bump the version).
I already disabled the hooks for DCD & Dscanner:
https://github.com/dlang-community/DCD/settings/hooks/14284880

Is there another project where you observe this random dependency errors?

Btw we might, of course, try to use git submodules and avoid using DUB entirely, which would be a workaound against the DUB problems ...

@ghost
Copy link

ghost commented Jun 12, 2017

Yes disable the hook for those that fail. Red crosses when the PR is clean are not acceptable. There were just those two so this OK for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant