Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashing on bad read #63

Open
arandomdev opened this issue Nov 21, 2020 · 1 comment
Open

Crashing on bad read #63

arandomdev opened this issue Nov 21, 2020 · 1 comment

Comments

@arandomdev
Copy link

Sometimes when nfc.read() and it fails to read the NDEF records the arduino crashes.

Stacktrace:
nfc.read()
MifareUltralight(uid, uidLength)
NdefMessage(buffer, messageLength()CRASH!

I think the issue is when the messageLength is set to 0, so fix this I suggest that we change the comparison operator in NdefMessage.cpp from:

`
...

while (index <= numBytes)

...`

to
`...

while (index < numBytes)

...`

@BenjaminKobjolke
Copy link

I had those crashes too when I switched between different nfc tags in fast succession.
This solved the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants