Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev containers do not have built-in plugins #14137

Open
Tracked by #14294
sgraband opened this issue Sep 5, 2024 · 7 comments · May be fixed by #14530
Open
Tracked by #14294

Dev containers do not have built-in plugins #14137

sgraband opened this issue Sep 5, 2024 · 7 comments · May be fixed by #14530
Assignees

Comments

@sgraband
Copy link
Contributor

sgraband commented Sep 5, 2024

Bug Description:

Currently dev containers are started without the built-in plugins of the "parent" application (e.g. Theia IDE).
This leads to the application behaving differently than outside of the dev container, for example the syntax highlighting is missing.
I do not think, that the creator of the devcontainer.json file should be responsible for specifying the built-in plugins, as one would expect that they are "part of the application".

Steps to Reproduce:

  1. Open a dev container
  2. Observe that there are no built-in plugins displayed in the extension view
  3. Check that plugins are not installed (e.g. settings page, no syntax highlighting, etc..)

Additional Information

  • Operating System: Ubuntu 22.04
  • Theia Version: Theia IDE 1.53.100
@msujew
Copy link
Member

msujew commented Sep 5, 2024

Note that this works in the Theia Dev Electron app:

image

@sgraband What application have you been using to replicate this? I was able to replicate it using the latest TheiaIDE.

See also #13369.

@sgraband
Copy link
Contributor Author

sgraband commented Sep 5, 2024

Thanks for the fast reply. I replicated it with Theia IDE 1.53.100 as well(also updated the ticket).

I will take a detailed look at the PR you linked in a minute, but would you expect this to work automatically with any product or are there some requirements on the products side to configure this/install the plugins in a certain way?

@msujew
Copy link
Member

msujew commented Sep 5, 2024

It might be that the localDir call here behaves somehow unexpected in a packaged environment. Generally, there is no configuration necessary for this feature to work.

@jonah-iden
Copy link
Contributor

@sgraband Could you provide us with some more information on how your plugins setup is? Do you set the --plugins option or the THEIA_DEFAULT_PLUGINS env variable? Are you installing some plugins manually before connecting with the container? Is it a pacakges electron distribution with an asar file?

@msujew
Copy link
Member

msujew commented Nov 25, 2024

@jonah-iden FYI I believe this is simply reproducible with the Theia IDE available from our website. No additional options necessary.

@jonah-iden jonah-iden self-assigned this Nov 25, 2024
@jonah-iden
Copy link
Contributor

@msujew ok thanks will try it out

@sgraband
Copy link
Contributor Author

@jonah-iden. Yes i was reporting this straight from the Theia IDE. Thanks for looking into it.

@jonah-iden jonah-iden linked a pull request Nov 26, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants