Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging with loguru not implemented correctly #184

Open
gomezzz opened this issue Jul 3, 2023 · 0 comments
Open

Logging with loguru not implemented correctly #184

gomezzz opened this issue Jul 3, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gomezzz
Copy link
Collaborator

gomezzz commented Jul 3, 2023

Issue

Problem Description

Current usage may overwrite loguru logger in other applications

Expected Behavior

Not interfering with user's logging

What Needs to be Done

Correct implementation is described here and here

How Can It Be Tested or Reproduced

Something along the lines of

from loguru import logger
logger.info("This should be printed")
import torchquad as tq
logger.info("This may not get printed I think")
@gomezzz gomezzz added the bug Something isn't working label Jul 3, 2023
@gomezzz gomezzz added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 11, 2023
arkinn47 pushed a commit to arkinn47/torchquad that referenced this issue Nov 1, 2024
…tly. Allows logging after importing torchquad.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant