chore(lint): unite eslint rules #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit f05e7ca and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 65.3% (0.0% change). View more on Code Climate. |
ala-n
requested changes
Oct 1, 2024
fshovchko
force-pushed
the
chore/unite-eslint-rules
branch
from
1dd5f6e
to
08e9caa
Compare
fshovchko
force-pushed
the
chore/unite-eslint-rules
branch
from
08e9caa
to
0d3fb61
Compare
fshovchko
requested review from
ala-n,
a team,
dshovchko and
NastaLeo
and removed request for
a team
ala-n
reviewed
Oct 2, 2024
ala-n
approved these changes
Oct 3, 2024
NastaLeo
approved these changes
Oct 4, 2024
dshovchko
approved these changes
Oct 4, 2024
|
🎉 This PR is included in version 5.0.0-beta.37 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2689
Even though original thought was to have only a single rule for each version, but it turned out to be incorrect from user's perspective. Pretty much we have 3 different rule cases:
If we combine all of them into one, there might be a case where the user has only path error. Since we declare our new combined rule as auto fixable, it will misinform user about us automatically fixing his problem. Which is false information.
That's why it was decided to only combine alias rules into one + refactor other rules to accept array of rule cases