Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 esl-popup]: add position-origin attribute #2746

Open
dshovchko opened this issue Nov 6, 2024 · 1 comment
Open

[🚀 esl-popup]: add position-origin attribute #2746

dshovchko opened this issue Nov 6, 2024 · 1 comment
Assignees
Labels
enhancement Improvements and additions to code released on @beta

Comments

@dshovchko
Copy link
Collaborator

As an ESL Popup consumer, I want to have the ability to set up popup in the manner to be placed over the trigger.

Currently, we have only position attributes. An example of a top position. It means placing a popup out of the trigger at the top.

sshot_2024-11-06-12-48-05

Proposal to add position-origin attribute with values "outer" (default and current behavior) and "inner". This attribute doesn't affect the side and direction of the popup placement. It defines the side of the trigger from which popup placing begins. So position-origin="inner" is used for cases when popup over the trigger.

sshot_2024-11-06-12-47-20

@dshovchko dshovchko added the enhancement Improvements and additions to code label Nov 6, 2024
@dshovchko dshovchko self-assigned this Nov 6, 2024
@ala-n
Copy link
Collaborator

ala-n commented Nov 11, 2024

🎉 This issue has been resolved in version 5.0.0-beta.39 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements and additions to code released on @beta
Projects
None yet
Development

No branches or pull requests

2 participants