Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider disallowing backslashes in MyST targets #37

Open
hukkin opened this issue Feb 1, 2022 · 2 comments · May be fixed by #38
Open

Consider disallowing backslashes in MyST targets #37

hukkin opened this issue Feb 1, 2022 · 2 comments · May be fixed by #38
Labels
enhancement New feature or request

Comments

@hukkin
Copy link
Member

hukkin commented Feb 1, 2022

Describe the problem/need and solution

Context
In mdit-py-plugins < 0.3 it backslashes were not allowed in MyST targets. Now they are.

Problem / Idea
This is now a valid MyST target:

(myst_target\)=

I think it would be more intuitive and in line with CommonMark if the backslash escape worked, i.e. prevented the target being parsed successfully.

Solution
Disallow backslashes in MyST targets.

Benefit
Consistency with backslashes in CommonMark.

Guide for implementation

No response

Tasks and updates

No response

@hukkin hukkin added the enhancement New feature or request label Feb 1, 2022
@welcome
Copy link

welcome bot commented Feb 1, 2022

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@chrisjsewell
Copy link
Member

Fair 👍 should be relative easy to make a PR 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants