Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSS for cell output scroll for MyST-NB #617

Open
choldgraf opened this issue Oct 4, 2022 · 1 comment
Open

Remove CSS for cell output scroll for MyST-NB #617

choldgraf opened this issue Oct 4, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@choldgraf
Copy link
Member

Context

MyST-NB is starting to bring in more CSS rules into its own package so that they are self-contained. We should remove MyST-NB rules from this package so that they aren't duplicated (at least unless we intentionally want the behavior to be different)

Proposal

Here's the PR that adds the lines to MyST-NB - we should basically remove the respective lines from this package:

Tasks and updates

No response

@dprada
Copy link

dprada commented Oct 4, 2022

As a user, I found intuitive the fact that I could scroll the cell's output with MyST-NB. I was probably wrong, maybe this is only explicitly written in the Jupyter Book documentation and not in MyST-NB... But that was intuition.

I am using MyST-NB with sphinx to write the documentation of a scientific python library, and I find MyST-NB extremely useful.
Maybe a custom style of the scroll bar should be included in the theme, but not the fact that these cell tags are functional.

Anyway, thanks a lot for keeping and developing these tools. 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants